-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global nav #536
Global nav #536
Conversation
Screen.Recording.2023-07-11.at.8.14.22.PM.mov |
app/src/components/common/Header.tsx
Outdated
|
||
function getInitials(name: string) { | ||
const splitName = name.split(' '); | ||
return splitName[0][0] + splitName[1][0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have more checks. For example, check if splitName
has more than 1 element.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulespinosa Thanks! Added a check for length and also to use the last element in case it's not just first and last name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
This PR includes the following updates to the global nav bar:
We aren't currently collecting the user's name so right now it uses a fake name.